Added Poetry support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmayshah99
added
the
Type: New Feature ➕
dvadym
reviewed
May 10, 2021
| pyspark = "^3.1.1" | ||
| absl-py = "^0.12.0" | ||
| dataclasses = {version = "^0.8", python = "~3.6"} | ||
| numpy = "<1.21" |
There was a problem hiding this comment.
Just wondering, why <1.21 version limitation? (which currently cover all current versions). Maybe it's better to specify lower bound (something like more than 1.17 or 1.20).
There was a problem hiding this comment.
Numpy has dropped support for python 3,6 starting 1.21.
dvadym
approved these changes
May 10, 2021
| pyspark = "^3.1.1" | ||
| absl-py = "^0.12.0" | ||
| dataclasses = {version = "^0.8", python = "~3.6"} | ||
| numpy = "<1.21" |
jspacek
pushed a commit
to jspacek/PipelineDP
that referenced
this pull request
May 15, 2021
* updated gitignore * added poetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for poetry. Poetry is a package management tool that helps to setup your environment super quickly. More on it here: https://python-poetry.org/
Checklist