Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explain plan to dp_engine and test #28

Merged
merged 2 commits into from
May 22, 2021
Merged

Add explain plan to dp_engine and test #28

merged 2 commits into from
May 22, 2021

Conversation

jspacek
Copy link
Member

@jspacek jspacek commented May 21, 2021

Description

Affected Dependencies

Part of #10

How has this been tested?

  • dp_engine_test adds two reports and checks that they are valid
  • Tested with conda environment under Python 3.8

Checklist

@jspacek jspacek added the Type: New Feature ➕ Introduction of a completely new addition to the codebase label May 21, 2021
dvadym
dvadym requested changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@dvadym dvadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good. I've left some a comment

pipeline_dp/dp_engine.py Outdated Show resolved Hide resolved
pipeline_dp/dp_engine.py Show resolved Hide resolved
@jspacek jspacek requested a review from dvadym May 21, 2021 19:35
dvadym
dvadym approved these changes May 22, 2021
View reviewed changes
Copy link
Collaborator

@dvadym dvadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dvadym dvadym merged commit 6adaab0 into OpenMined:main May 22, 2021
@jspacek jspacek deleted the explain-plan-engine branch May 30, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvadym dvadym dvadym approved these changes

@chinmayshah99 chinmayshah99 Awaiting requested review from chinmayshah99

Assignees
No one assigned
Labels
Type: New Feature ➕ Introduction of a completely new addition to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspacek @dvadym