Add logic for finding max_sum_per_partition candidates
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ysis for sum is not yet implemented.
RamSaw
commented
Aug 25, 2023
RamSaw
commented
Aug 25, 2023
dvadym
reviewed
Aug 25, 2023
analysis/parameter_tuning.py
Outdated
| @@ -139,6 +138,11 @@ def _find_candidate_parameters( | |||
| l0_bounds = linf_bounds = None | |||
| max_sum_per_partition_bounds = min_sum_per_partition_bounds = None | |||
|
|
|||
| if calculate_sum_per_partition_param: | |||
| assert not parameters_to_tune.min_sum_per_partition, "Tuning of min_sum_per_partition is not supported yet" | |||
There was a problem hiding this comment.
Please put this check in _check_tune_args
There was a problem hiding this comment.
added, wdyt? afaiu options.parameters_to_tune.min_sum_per_partition should never be true because we don't support it in any cases.
There was a problem hiding this comment.
Yes, agree that tuning min_sum_per_partition should be false for now
analysis/parameter_tuning.py
Outdated
| find_candidates_func1: Callable[[histograms.Histogram, int], | ||
| Sequence[Number]], | ||
| find_candidates_func2: Callable[[histograms.Histogram, int], | ||
| Sequence[Number]], max_candidates: int): |
There was a problem hiding this comment.
Nit: please add docstring for this function (it has pretty complicated API)
dvadym
reviewed
Aug 28, 2023
analysis/parameter_tuning.py
Outdated
| find_candidates_func1: Callable[[histograms.Histogram, int], | ||
| Sequence[Number]], | ||
| find_candidates_func2: Callable[[histograms.Histogram, int], | ||
| Sequence[Number]], max_candidates: int): |
analysis/parameter_tuning.py
Outdated
| @@ -139,6 +138,11 @@ def _find_candidate_parameters( | |||
| l0_bounds = linf_bounds = None | |||
| max_sum_per_partition_bounds = min_sum_per_partition_bounds = None | |||
|
|
|||
| if calculate_sum_per_partition_param: | |||
| assert not parameters_to_tune.min_sum_per_partition, "Tuning of min_sum_per_partition is not supported yet" | |||
There was a problem hiding this comment.
Yes, agree that tuning min_sum_per_partition should be false for now
dvadym
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
linf_sum_contributions_histogramto compute that, candidates are taken as max values of bins, bins are sampled uniformly.min_sum_per_partition is not implemented and is always zero.
utility analysis for sum was not implemented, this PR also adds support for it modifying
_sum_metrics_to_data_droppedmethod.