Fix release workflow #143
Merged
Fix release workflow #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philomath213
added
Build
youben11
approved these changes
Aug 23, 2020
pierreeliseeflory
pushed a commit
to pierreeliseeflory/TenSEAL
that referenced
this pull request
Apr 27, 2022
* add install requirements script for centos * fix release workflow for linux * fix release workflow for macos * format release workflow for windows * update build script for windows * format workflows YML files * always checkout with submodules * remove submodules initialize and updating in scripts * remove submodules initialize and updating in docker files * Set missing submodules argument in actions/checkout * switch to actions/checkout v1 since manylinux2010_x86_64 don't work on v2 * use protobuf linux binary release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were using
install_req_ubuntu.shscript in Linux release workflow in order to install packages and dependencies, but that release workflow is actually usingquay.io/pypa/manylinux2010_x86_64container which is a CentOS 5 Linux container.This PR introduce new script for CentOS 5 in order to setup the requirement, with a minor changes to Windows and MacOS workflow (small improvement).
Regarding protobuf for CentOS script, I used the binary release instead of source tarball in order to avoid compiling protobuf (it's take a lot of time btw).
Affected Dependencies
How has this been tested?
manylinuxcontainer.Checklist