Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpp library improvements #167

Merged
merged 38 commits into from
Nov 24, 2020
Merged

Cpp library improvements #167

merged 38 commits into from
Nov 24, 2020

Conversation

bcebere
Copy link
Member

@bcebere bcebere commented Nov 24, 2020 •
edited
Loading

Description

  • PlainTensor iterator support
  • Move some duplicated code to EncryptedTensor interface

Checklist

bcebere added 30 commits October 18, 2020 16:54
@bcebere
WIP: use shared_ptr for tensor API
ab26966
@bcebere
WIP: use shared_ptr for tensors API
398c94f
@bcebere
WIP: use shared_ptr in tensor API
43ee4ec
@bcebere
update some tests
32a49f7
@bcebere
update tests
b6e88a6
@bcebere
add tenseal.h library header
51de7b4
@bcebere
initial tensor interface
ee07c16
@bcebere
update tests
a0047f8
@bcebere
move common logic to tensor.cpp
6f5fca2
@bcebere
update cmake file
200ca6b
@bcebere
port bfvvector to encrypted tensor too
797c873
@bcebere
move encrypt to cpp
603f057
@bcebere
update tests
364bf9b
@bcebere
update ctx settings for BFV
4541722
@bcebere
update pack_vectors
70515a8
@bcebere
add protected fields
0b685d2
@bcebere
tensor -> vector
4a6e40a
@bcebere
update cpp tests
ba6dbda
@bcebere
templated encrypted vector
450ec15
@bcebere
rework Create flow
976ee04
@bcebere
cleanup create flow
0a4b0fc
@bcebere
rename files
01db3c0
@bcebere
lint
2324bd6
@bcebere
add encrypted tensor interface
48ce2ca
@bcebere
cleanup encrypted_vector interface, every inplace op is implemented i…
9e8dbdd 
…n the derived class
@bcebere
cleanup interfaces
8d58e85
@bcebere
API cleanup
2075aec
@bcebere
add plain_tensor
898a6b1
@bcebere
remove unecessary copies
1909573 
Fixes #154
@bcebere
update some docs
9fe5cd7
@bcebere bcebere requested a review from youben11 November 24, 2020 11:59
youben11
youben11 approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!

@youben11 youben11 merged commit 2c976f0 into master Nov 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the cpp_library_improvements branch November 24, 2020 13:39
pierreeliseeflory pushed a commit to pierreeliseeflory/TenSEAL that referenced this pull request Apr 27, 2022
@bcebere
Cpp library improvements (OpenMined#167)
f37a770 
* WIP: use shared_ptr for tensor API

* WIP: use shared_ptr for tensors API

* WIP: use shared_ptr in tensor API

* update some tests

* update tests

* add tenseal.h library header

* initial tensor interface

* update tests

* move common logic to tensor.cpp

* update cmake file

* port bfvvector to encrypted tensor too

* move encrypt to cpp

* update tests

* update ctx settings for BFV

* update pack_vectors

* add protected fields

* tensor -> vector

* update cpp tests

* templated encrypted vector

* rework Create flow

* cleanup create flow

* rename files

* lint

* add encrypted tensor interface

* cleanup encrypted_vector interface, every inplace op is implemented in the derived class

* cleanup interfaces

* API cleanup

* add plain_tensor

* remove unecessary copies
Fixes OpenMined#154

* update some docs

* docs + cleanup

* use const ref everywhere

* some cleanup

* add iterator support for PlainTensor

* remove duplicated decrypt code

* use the new tensor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youben11 youben11 youben11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcebere @youben11