-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CKKSTensor serialization #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great! I just left a small remark
tenseal/proto/tensors.proto
Outdated
// The strides of the encrypted tensor | ||
repeated uint32 strides = 2; | ||
// The serialized ciphertext | ||
repeated bytes ciphertext = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have a vector of ciphertexts here, I assume this declaration already support that, but maybe we can make it more explicit with ciphertexts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"repeated" keyword is a vector for protobuffers.
I will update the name.
* add CKKSTensor serialization * add serialization tests for ckkstensor * update protobuffers
Description
Add CKKSTensor protobuf support.
Fixes #166
Checklist