Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CKKSTensor serialization #168

Merged
merged 8 commits into from
Nov 27, 2020
Merged

add CKKSTensor serialization #168

merged 8 commits into from
Nov 27, 2020

Conversation

bcebere
Copy link
Member

@bcebere bcebere commented Nov 27, 2020

Description

Add CKKSTensor protobuf support.
Fixes #166

Checklist

@bcebere bcebere changed the title [WIP]add CKKSTensor serialization add CKKSTensor serialization Nov 27, 2020
@bcebere bcebere requested a review from youben11 November 27, 2020 12:31
Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! I just left a small remark

// The strides of the encrypted tensor
repeated uint32 strides = 2;
// The serialized ciphertext
repeated bytes ciphertext = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have a vector of ciphertexts here, I assume this declaration already support that, but maybe we can make it more explicit with ciphertexts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"repeated" keyword is a vector for protobuffers.

I will update the name.

@bcebere bcebere requested a review from youben11 November 27, 2020 14:19
@bcebere bcebere merged commit 7b6b584 into master Nov 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the ckks_tensor_improvements branch November 27, 2020 14:48
pierreeliseeflory pushed a commit to pierreeliseeflory/TenSEAL that referenced this pull request Apr 27, 2022
* add CKKSTensor serialization

* add serialization tests for ckkstensor

* update protobuffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKKSTensor - save, load and copy
2 participants