CKKSTensor Dot operation #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
added
the
Type: New Feature ➕
bcebere
requested changes
Dec 22, 2020
| shared_ptr<CKKSTensor> matmul(const shared_ptr<CKKSTensor> other) { | ||
| return this->copy()->matmul_inplace(other); | ||
| } | ||
| shared_ptr<CKKSTensor> matmul_inplace(const shared_ptr<CKKSTensor> other); |
There was a problem hiding this comment.
There is something similar in the encrypted_vector interface. Maybe move them to the encrypted_tensor interface?
There was a problem hiding this comment.
True! This will require removing the n_jobs parameter from matmul, which I can't remember why I chose to put it there... I will open another PR for the API change after this one.
bcebere
approved these changes
Dec 23, 2020
| } | ||
| return true; | ||
| }; | ||
|
|
There was a problem hiding this comment.
we should somehow reuse the workers code, it is a lot of duplication here.
but for another PR.
There was a problem hiding this comment.
Yeah, I literally did a copy/paste here. I will open two refactor issues that I've found useful to work on
pierreeliseeflory
pushed a commit
to pierreeliseeflory/TenSEAL
that referenced
this pull request
Apr 27, 2022
* first skeleton for dot operation * matmul * lint * tests * fix: create acc ct based on result param_id * lint * rename test func * fix indexing * redef API for dot dot_product* is now just dot* * lint * plain dot * comments * bind plain dot * parallel matmul * fix: to_sum should be scoped in the worker_func only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the dot operation between a CKKSTensor and another, or a PlainTensor. The shapes supported now are 1D-1D (inner product) and 2D-2D (matrix multiplication).
TODO
Fixes #176
How has this been tested?
Checklist