ignoring zero diagonals in diagonal_ct_vector_matmul #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in #398, matrices with diagonals that contain nothing but zeros cannot be multiplied with a vector, as this results in
ValueError: result ciphertext is transparent
. This can be fixed by simply ignoring zero diagonals, which in addition potentially saves some unnecessary computations.Affected Dependencies
None
How has this been tested?
I used the following code to test, which previously resulted in the error explained above.
Checklist