Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint support #62

Closed
cereallarceny opened this issue Dec 5, 2019 · 3 comments
Closed

Add eslint support #62

cereallarceny opened this issue Dec 5, 2019 · 3 comments
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! help wanted Javascript team

Comments

@cereallarceny
Copy link
Member

We need help adding ESLint to syft.js so that we can more readily detect style issues in our code. Ideally, all configs would be set to error so that we have failing tests until the code is properly written.

This issue is a bit non-descript, so if you're interested in helping configuring ESLint properly, please contact me (@cereallarceny) on Slack and I'll get you started!

@cereallarceny cereallarceny added help wanted Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Javascript team labels Dec 5, 2019
@cereallarceny
Copy link
Member Author

Ideally we would use eslint: recommended with the strict rule set to ['error', 'never'].

@ghost
Copy link

ghost commented Dec 5, 2019

hi, i'd like to try this

@cereallarceny
Copy link
Member Author

Alright @robertbegna! It's yours. Hit me up in Slack if you have questions. I'm happy to assist. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! help wanted Javascript team
Projects
None yet
Development

No branches or pull requests

1 participant