Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint setup #102

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Eslint setup #102

merged 2 commits into from
Feb 26, 2020

Conversation

rav1kantsingh
Copy link
Member

@rav1kantsingh rav1kantsingh commented Feb 26, 2020

#62
For review by @cereallarceny

Copy link
Member

@cereallarceny cereallarceny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IamRavikantSingh A few initial questions I have. Also, this doesn't actually run ESLint as part of the watch or build commands in package.json. Please ensure that ESLint is actually running via the CLI commands and not via your code editor.

.eslintrc.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #102 into master will decrease coverage by 13.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #102       +/-   ##
===========================================
- Coverage   85.97%   72.48%   -13.49%     
===========================================
  Files          18       18               
  Lines         556      556               
  Branches       80       80               
===========================================
- Hits          478      403       -75     
- Misses         67      123       +56     
- Partials       11       30       +19
Impacted Files Coverage Δ
src/types/message.js 23.52% <0%> (-60.79%) ⬇️
src/types/protocol.js 50% <0%> (-50%) ⬇️
src/syft.js 18.47% <0%> (-29.35%) ⬇️
src/types/plan.js 68.18% <0%> (-27.28%) ⬇️
src/protobuf/index.js 72% <0%> (-20%) ⬇️
src/types/placeholder.js 90% <0%> (-10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b174d1a...8035240. Read the comment docs.

@cereallarceny cereallarceny merged commit 2ce2608 into OpenMined:master Feb 26, 2020
@rav1kantsingh rav1kantsingh deleted the add-eslint branch February 26, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants