Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint error fix #104

Merged
merged 3 commits into from
Mar 1, 2020
Merged

Conversation

rav1kantsingh
Copy link
Member

@rav1kantsingh rav1kantsingh commented Feb 27, 2020

package.json Outdated Show resolved Hide resolved
test/data_channel_message.test.js Outdated Show resolved Hide resolved
test/data_channel_message.test.js Outdated Show resolved Hide resolved
test/data_channel_message_queue.test.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #104 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files          18       18           
  Lines         556      556           
  Branches       80       80           
=======================================
  Hits          478      478           
  Misses         67       67           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6304b72...25e42fa. Read the comment docs.

@cereallarceny
Copy link
Member

For the record, we won't be merging this PR until we have 100% passing tests. We don't need to have 100% test coverage, but we need all failing tests and linting errors to be resolved.

@rav1kantsingh
Copy link
Member Author

For the record, we won't be merging this PR until we have 100% passing tests. We don't need to have 100% test coverage, but we need all failing tests and linting errors to be resolved.

This pr only contains eslint error fix and for jest test fails I am working on another Pr #105

@vvmnnnkv
Copy link
Member

vvmnnnkv commented Mar 1, 2020

Thanks!

@vvmnnnkv vvmnnnkv merged commit 5898738 into OpenMined:master Mar 1, 2020
@rav1kantsingh rav1kantsingh deleted the eslint-error-fix branch March 2, 2020 07:20
@rav1kantsingh rav1kantsingh changed the title Eslint error fixed Eslint error fix Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants