Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyGrid integration #109

Merged
merged 1 commit into from
Mar 13, 2020
Merged

PyGrid integration #109

merged 1 commit into from
Mar 13, 2020

Conversation

vvmnnnkv
Copy link
Member

@vvmnnnkv vvmnnnkv commented Mar 12, 2020

This PR adds following changes:

  • websocket, http support added in GridAPIClient (selected depending on provided pygrid URL)
  • authenticate, cycle-request, get-model, get-plan, report are doing actual pygrid requests
  • model diff is actually serialized to protobuf and sent to pygrid (report request)

It was tested with following notebooks:
OpenMined/PySyft#3185
And this PyGrid branch: OpenMined/PyGrid-deprecated---see-PySyft-#509

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #109 into master will decrease coverage by 6.76%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   77.86%   71.10%   -6.77%     
==========================================
  Files          21       21              
  Lines         610      713     +103     
  Branches       81       93      +12     
==========================================
+ Hits          475      507      +32     
- Misses        118      183      +65     
- Partials       17       23       +6     
Impacted Files Coverage Δ
src/job.js 0.00% <0.00%> (ø)
src/syft_model.js 0.00% <0.00%> (ø)
src/grid-api-client.js 9.63% <10.66%> (-0.89%) ⬇️
src/types/plan.js 91.66% <80.00%> (+0.75%) ⬆️
src/protobuf/index.js 94.73% <92.30%> (-1.27%) ⬇️
src/types/message.js 83.33% <100.00%> (ø)
src/types/placeholder.js 100.00% <100.00%> (ø)
src/types/torch.js 93.54% <100.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0b999...864cdff. Read the comment docs.

@cereallarceny cereallarceny changed the title [WIP] PyGrid integration PyGrid integration Mar 13, 2020
@cereallarceny cereallarceny merged commit dd40a00 into master Mar 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the vvm/pygrid branch March 13, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants