Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire with PyGrid report #110

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Wire with PyGrid report #110

merged 3 commits into from
Mar 20, 2020

Conversation

vvmnnnkv
Copy link
Member

@vvmnnnkv vvmnnnkv commented Mar 19, 2020

PR changes:

  • update to new websocket response format in pygrid
  • Model params serialization fixed to work with pygrid
  • GPU mem leaks addressed

Example is tested with FL hosted from experimental notebooks: OpenMined/PySyft#3224
and with pygrid branch OpenMined/PyGrid-deprecated---see-PySyft-#518
and shows multiple cycles of training and model params averaging!

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #110 into master will increase coverage by 0.4%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #110     +/-   ##
=========================================
+ Coverage   71.27%   71.67%   +0.4%     
=========================================
  Files          21       22      +1     
  Lines         724      752     +28     
  Branches       96       98      +2     
=========================================
+ Hits          516      539     +23     
- Misses        184      188      +4     
- Partials       24       25      +1
Impacted Files Coverage Δ
src/_helpers.js 95.45% <ø> (ø) ⬆️
src/syft-model.js 0% <0%> (ø)
src/job.js 0% <0%> (ø) ⬆️
src/types/torch.js 94.28% <100%> (+0.73%) ⬆️
src/syft.js 15.09% <100%> (ø) ⬆️
src/grid-api-client.js 14.44% <40%> (+1.65%) ⬆️
src/types/message.js 83.6% <50%> (ø) ⬆️
src/types/plan.js 92.3% <91.66%> (+0.64%) ⬆️
src/object-registry.js 92.85% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06293da...91dfa9f. Read the comment docs.

@cereallarceny cereallarceny merged commit e570ba4 into master Mar 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the vvm/pygrid-report branch March 20, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants