Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure web-socket connection for GridAPIClient #111

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Secure web-socket connection for GridAPIClient #111

merged 2 commits into from
Mar 19, 2020

Conversation

rav1kantsingh
Copy link
Member

@rav1kantsingh rav1kantsingh commented Mar 19, 2020 •
edited by cereallarceny
Loading

Closes #77
@vvmnnnkv

@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited
Loading

Codecov Report

Merging #111 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   71.15%   71.27%   +0.11%     
==========================================
  Files          21       21              
  Lines         721      724       +3     
  Branches       95       96       +1     
==========================================
+ Hits          513      516       +3     
  Misses        184      184              
  Partials       24       24
Impacted Files Coverage Δ
src/grid-api-client.js 12.79% <100.00%> (+3.15%) ⬆️
src/syft.js 15.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f9dc4...c9999d9. Read the comment docs.

@vvmnnnkv vvmnnnkv self-requested a review March 19, 2020 05:28
vvmnnnkv
vvmnnnkv requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@vvmnnnkv vvmnnnkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also force http to https

@cereallarceny cereallarceny self-requested a review March 19, 2020 10:51
This was referenced Mar 19, 2020
Closed
Closed
@cereallarceny cereallarceny merged commit 06293da into OpenMined:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cereallarceny cereallarceny cereallarceny approved these changes

@vvmnnnkv vvmnnnkv Awaiting requested review from vvmnnnkv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[syft.js] Force all insecure websocket connections to be secure
3 participants
@rav1kantsingh @cereallarceny @vvmnnnkv