Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make up-to-date with protobuf and Plan changes in PySyft #151

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Make up-to-date with protobuf and Plan changes in PySyft #151

merged 2 commits into from
Jun 8, 2020

Conversation

vvmnnnkv
Copy link
Member

@vvmnnnkv vvmnnnkv commented Jun 7, 2020

Description

Changes:

  • Update to latest syft-proto version to be able to unserialize Plans, etc.
  • Update protobuf unserialization code to work with latest schemas
  • Had to resurrect part of legacy torch->tfjs translation because Threepio doesn't support following commands:
    • dim, copy, rdiv, and keepdim kwarg in sum.
  • Also, Threepio doesn't support inplace ops, so there's hack for add_.
  • Update MNIST unit test to check that MNIST Plan executed in js and python produce same loss, accuracy and model weights (up to certain precision).

Checklist

@vvmnnnkv
Update code to work with latest pysyft and syft-proto, update MNIST u…
6ebe53b 
…nit test to check that Plan results are close to python
@vvmnnnkv vvmnnnkv mentioned this pull request Jun 7, 2020
Closed
@vvmnnnkv
Copy link
Member Author

vvmnnnkv commented Jun 7, 2020

Fixes #148

@cereallarceny cereallarceny merged commit 5a9f60a into master Jun 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/protobuf-and-mnist branch June 8, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cereallarceny cereallarceny cereallarceny approved these changes

@Nolski Nolski Awaiting requested review from Nolski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvmnnnkv @cereallarceny