Documentation: src/types/message.js #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahuakang
added
the
Type: Documentation 📚
cereallarceny
approved these changes
Aug 5, 2020
|
@vvmnnnkv I'm good with this PR, please merge and close the original issue if you don't have any changes. |
vvmnnnkv
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #133 and adds inline documentation to the message types currently implemented (but not used).
@vvmnnnkv Let me know if the documentation to
ObjectMessage, especially the static methodunbufferize, is correct or not. Still not sure ifprotobuf.syft_proto.messaging.v1.ObjectMessageis the correct way to document the type 🙏Affected Dependencies
N/A
How has this been tested?
N/A
Checklist