Test - src/sockets.js #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahuakang
added
Type: Documentation 📚
cereallarceny
approved these changes
Aug 10, 2020
|
@nahuakang Are you doing anything in this PR that we weren't already doing previously? |
@cereallarceny No, unit-test-wise the file seems quite comprehensive. Only added comments in case other beginning contributors get confused about the code like I did (plus the syntax fix such as brackets around an arrow function input, etc.). |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #144 .
Note that no additional unit tests are added since the current tests are comprehensive. Inline comments are added especially in the early sections of the test so that future contributors can jump on easily.
Affected Dependencies
N/A
How has this been tested?
N/A
Checklist