Add protobuf for Plan; update Plan execution #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #83, this PR updates Plan class to match latest PySyft version, and adds support for deserializing Plan from protobuf.
Additionally, it updates Plan execution to work with new Plan & Placeholders.
With-grid example works with new protocol ID, added in grid.js PR: ...
Note that all Protocol/Plan data in this grid.js PR is serialized in protobuf, and with-grid example works from it.
I had to skip existing serde and some Plan/Operation/etc. tests because they test or depend on old serde, and I'm not sure we want to support it further.
@cereallarceny do you think we should keep old serde serialization?