Move tfjs dependency; fix with-node example warnings #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #97:
1 (with-node example warnings problem):
with-grid
example is fixed to not include tfjs into bundle because it's already included in index.html (this solves double init warnings).Additionally:
rollup-plugin-peer-deps-external
that automatically excludes peerDependencies from syft.js bundle.tfjs-code
. Currently we don't need layer API, so we don't have to require it to be installed.2 (warnings about tfjs-node during unit tests):
One solution to that could be including tfjs-node in dev dependencies, but I found this involves TF C++ bindings compilation step when you do
npm install
, which can be even more annoying than warnings during tests.Note:
I checked tfjs model packages, and it seems we do similar.
E.g. a library with the model https://github.com/tensorflow/tfjs-models/tree/master/posenet using rollup and also having tfjs as peer dependency.