Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated embrace use case #1016

Merged
merged 9 commits into from
Jul 6, 2021
Merged

Updated embrace use case #1016

merged 9 commits into from
Jul 6, 2021

Conversation

robha67
Copy link
Contributor

@robha67 robha67 commented Apr 26, 2021

Related Issues

Updated use-case with a simulink generated SW FMU. The use-case now include "bus-to-bus" type connections including a int to enum connection.

Purpose

Open test platform capturing end-user requirements on OMSimulator

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2021

CLA assistant check
All committers have signed the CLA.

@stale
Copy link

stale bot commented Jun 4, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 4, 2021
@stale
Copy link

stale bot commented Jun 16, 2021

Closing this pull request after a prolonged period of inactivity. If this is still relevant, please feel free to create a new pull request with up-to-date information.

@stale stale bot closed this Jun 16, 2021
@arun3688 arun3688 removed the stale label Jun 17, 2021
@lochel
Copy link
Member

lochel commented Jul 5, 2021

Sorry, this was closed by accident.

@lochel lochel reopened this Jul 5, 2021
@lochel
Copy link
Member

lochel commented Jul 5, 2021

@robha67 Sorry that it took so long, but now the example is adapted to the test suite setup and should hopefully pass all checks.

@lochel
Copy link
Member

lochel commented Jul 6, 2021

@robha67 I had to reduce the stopTime from 1200 to 12 in order to make the test pass in reasonable time. Please let me know if you see any problem with that.

@lochel lochel merged commit 65fcf59 into OpenModelica:master Jul 6, 2021
@robha67
Copy link
Contributor Author

robha67 commented Jul 6, 2021

I could imagine that the longer time step could cause some instability problems and erranous results. Is the OM simulator checked for numerical stability? If not, then I don't see a problem. @lochel

@lochel
Copy link
Member

lochel commented Jul 7, 2021

I didn't change the step size. The simulation just terminates at stopTime=12 instead of stopTime=1200 because the test case otherwise takes way too much time.

@robha67
Copy link
Contributor Author

robha67 commented Jul 7, 2021

Oh, ok. Then I missunderstood you. I see no reason to run the entire mission. I guess a longer simulation is needed to se the effect concerning the potential issue of increasing overhead but I believe that investigation is best done "off-line"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants