Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce flag --zeroNominal #1018

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Introduce flag --zeroNominal #1018

merged 1 commit into from
Apr 27, 2021

Conversation

lochel
Copy link
Member

@lochel lochel commented Apr 27, 2021

Related Issues

Description

The new flag will force 1.0 as nominal values for all invalid nominal values. It also changes the error messages slightly.

Copy link
Member

@AnHeuermann AnHeuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lochel lochel enabled auto-merge (squash) April 27, 2021 20:05
@lochel lochel merged commit fa408db into OpenModelica:master Apr 27, 2021
@lochel lochel deleted the nominal branch April 27, 2021 20:17
@max-privato
Copy link

This will be activated in OMEdit with --zeroNominal=true , guess? (as per the following picture).
If the answer is yes I must wait for tomorrow's nightly build, since today's (dev-246) does not accept this flag.

In the meanwhile, I've tried also to manually set nominal=1 in the original modelica file, and this gave rise to other issues with OM/SSP, that I will report in another ticket, once I've sussessfully tried this flag.

Thanks a lot for your very fast and effective support!

flags

@lochel
Copy link
Member Author

lochel commented Apr 29, 2021

The answer is yes, although a bit late ;)

@max-privato
Copy link

max-privato commented Apr 29, 2021

great addition!

I'll use it all the time... up to when Dassault fixes Dymola. Claytex has acknowledged Dymola has a fault and passed my report to the developers (I sent a copy of the mail to @casella ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants