Simplify ssv related code in class Model #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e7d0cce.
arun3688
reviewed
Feb 15, 2021
src/OMSimulatorLib/System.cpp
Outdated
| @@ -1689,6 +1692,9 @@ bool oms::System::copyResources() | |||
|
|
|||
| void oms::System::getAllResources(std::vector<std::string>& resources) const | |||
| { | |||
| if (!values.empty() && !Flags::ExportParametersInline()) | |||
There was a problem hiding this comment.
this will not work, and values.empty() will always be false and the ssv files will not be pushed to resources
There was a problem hiding this comment.
Why will values.empty() always be false?
arun3688
reviewed
Feb 15, 2021
src/OMSimulatorLib/System.cpp
Outdated
| @@ -1689,6 +1692,9 @@ bool oms::System::copyResources() | |||
|
|
|||
| void oms::System::getAllResources(std::vector<std::string>& resources) const | |||
| { | |||
| if (!values.empty() && !Flags::ExportParametersInline()) | |||
| resources.push_back("resources/" + std::string(this->getFullCref()) + ".ssv"); | |||
There was a problem hiding this comment.
the ssv file can be pushed directly in exportoFile() in Model.cpp which is easily understandable i guess
There was a problem hiding this comment.
values contain all the values that will be exported to the ssv file, right? Therefore, it would make sense to move everything ssv related to that class. I am not quite sure why it didn't work, but I would still like to move those things there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just simplifying some of the existing code.