Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the initial unknowns once and for all #998

Merged
merged 15 commits into from
Mar 26, 2021
Merged

Fix the initial unknowns once and for all #998

merged 15 commits into from
Mar 26, 2021

Conversation

lochel
Copy link
Member

@lochel lochel commented Mar 25, 2021 •
edited
Loading

Related Issues

Not reported; or already closed.

Purpose

  • Detect wrong initial unknowns if possible and report them.
  • Only consider --ignoreInitialUnknowns=true for FMUs with bad initial unknowns.
  • Re-enable AircraftVehicleDemonstrator

@lochel lochel added the CI/MINGW32 Activate mingw32 build and test in PR label Mar 26, 2021
@lochel lochel requested a review from AnHeuermann March 26, 2021 15:53
@lochel lochel removed the CI/MINGW32 Activate mingw32 build and test in PR label Mar 26, 2021
@lochel lochel changed the title Revert workaround for initial unknowns Fix the initial unknowns once and for all Mar 26, 2021
@lochel
Copy link
Member Author

lochel commented Mar 26, 2021

@AnHeuermann Thanks for your support! I think this is now in good shape and could be merged soon.

@lochel lochel merged commit 0165678 into OpenModelica:master Mar 26, 2021
@lochel lochel deleted the aircraft branch March 26, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnHeuermann AnHeuermann Awaiting requested review from AnHeuermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lochel