Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback looping doesn't respect "Times to loop" property #406

Open
IoeCmcomc opened this issue Jun 13, 2023 · 0 comments
Open

Playback looping doesn't respect "Times to loop" property #406

IoeCmcomc opened this issue Jun 13, 2023 · 0 comments
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Milestone

Comments

@IoeCmcomc
Copy link

Describe the bug
When playing a song with looping is enabled in the editor, the editor always loop infinite times. The "Times to loop" song property is simply ignored, while the "Loop start tick" property is taken into account.

To Reproduce
Steps to reproduce the behavior:

  1. Open any song
  2. Make sure looping is enabled in the toolbar
  3. Go to Settings -> Song properties...
  4. Enable the song's looping and set its max loop count to a non-zero number
  5. Click OK
  6. Save the file
  7. Play the song
  8. See the song is looped infinitely

Expected behavior
The editor should loop the number of times specified in the song properties, with the exception of 0 (infinite).

Screenshots
image
The highlighted property is ignored by the program.

Additional context
Version: 3.10.0
OS: Windows 11 64-bit

@Bentroen Bentroen added the C: Bug Something isn't working label Jun 19, 2023
IoeCmcomc added a commit to IoeCmcomc/OpenNoteBlockStudio that referenced this issue Apr 22, 2024
@Bentroen Bentroen added the S: Resolved in next release This bugfix or suggestion has been applied to the code label Jul 9, 2024
@Bentroen Bentroen added this to the v3.10.1 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Projects
None yet
Development

No branches or pull requests

2 participants