Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B #6689: append --block to change-media call in reconfigure #6690

Closed
wants to merge 1 commit into from
Closed

B #6689: append --block to change-media call in reconfigure #6690

wants to merge 1 commit into from

Conversation

atodorov-storpool
Copy link
Contributor

@atodorov-storpool atodorov-storpool commented Aug 9, 2024 •
edited by 1gramos
Loading

Description

when the $ISO_PATH is a block device.
So libvirt's change media should be called with additional argument -block

Branches to which this PR applies

  • master
  • one-6.10
  • Check this if this PR should not be squashed

@rsmontero rsmontero added this to the Release 6.10.1 milestone Sep 3, 2024
@1gramos 1gramos self-requested a review October 4, 2024 08:22
@rsmontero
Copy link
Member

THANKS! Merged as per d5b5a4d

This will be also included in 6.10.1 release

@rsmontero rsmontero closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1gramos 1gramos 1gramos approved these changes

Assignees

@1gramos 1gramos

Labels
Category: Drivers - Storage Priority: Normal Sponsored Status: Accepted Type: Feature
Projects
None yet
Milestone
Release 6.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@atodorov-storpool @rsmontero @1gramos