Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opennebula_service: Add "timeouts" block #467

Closed
sk4zuzu opened this issue Jul 13, 2023 · 2 comments · Fixed by #487
Closed

opennebula_service: Add "timeouts" block #467

sk4zuzu opened this issue Jul 13, 2023 · 2 comments · Fixed by #487

Comments

@sk4zuzu
Copy link
Collaborator

sk4zuzu commented Jul 13, 2023

Description

  1. It seems that timeout for opennebula_service resource is hardcoded to 3 minutes -> https://github.com/OpenNebula/terraform-provider-opennebula/blob/v1.2.2/opennebula/resource_opennebula_service.go#L712, which for something like OneKE appliance is too small and it always fails because of that.
  2. Resources like opennebula_image already support "timeouts" block -> https://github.com/OpenNebula/terraform-provider-opennebula/blob/v1.2.2/opennebula/resource_opennebula_image.go#L35-L38.
  3. It would be great to have same feature for opennebula_service. 👍 🙂

New or affected resources and data sources

  • opennebula_service

Potential terraform configuration

resource "opennebula_service" "example" {
  name           = "service"
  template_id    = 11
  extra_template = templatefile("${path.module}/extra_template.json", {})
  timeouts {
    create = "15m"
    delete = "5m"
  }
}

References

https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/retries-and-customizable-timeouts

@treywelsh
Copy link
Collaborator

treywelsh commented Aug 23, 2023

Sorry I didn't see that the issue was assigned so I just made a PR, I'll take this one, I'll take care to assign myself to an issue before working on it in the future

@treywelsh treywelsh assigned treywelsh and unassigned vickmp Aug 23, 2023
@tinova
Copy link
Member

tinova commented Aug 23, 2023

no worries! glad that this is underway :)

treywelsh added a commit that referenced this issue Aug 28, 2023
@frousselet frousselet modified the milestones: 1.3.2, 1.3.1 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants