Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of first ip for network reservations #274

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

treywelsh
Copy link
Collaborator

This is a PR that apply some small changes to #185 authored by @danhigham

@treywelsh
Copy link
Collaborator Author

treywelsh commented May 24, 2022

This PR introduce the reservation_ar_id attribute.
It's easy to retrieve with an already existing AR but we may want to be able to create a reservation at the same time that we create the AR in the parent network.
In addition, it's not possible to rely on address range order to guess the ID (ARs are stored in a TypeSet. We could store them in a TypeList instead, but keep AR ordering through future AR modification is not so funny).

I don't see any easy and clean way to work with reservation_ar_id other than externalize the address range to it's own resource (but it's not the only argument to do this anyway): #279

I'll remove this issue from 0.5.0 milestone, it will require a bit more of work

@treywelsh treywelsh modified the milestones: 0.5.0, 0.6.0 May 24, 2022
@treywelsh
Copy link
Collaborator Author

depends on #279 should be scheduled for 1.0 release

@treywelsh treywelsh modified the milestones: v0.5.1, v1.0.0 Jun 3, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@treywelsh
Copy link
Collaborator Author

rebased on top of #306 until it's merged to make this PR move forward

@treywelsh treywelsh force-pushed the vnet_first_ip branch 3 times, most recently from 56dc88c to 99d3b23 Compare August 30, 2022 09:00
@treywelsh treywelsh marked this pull request as ready for review August 30, 2022 13:58
CHANGELOG.md Outdated Show resolved Hide resolved
@frousselet frousselet merged commit 360605f into OpenNebula:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants