Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-283: fail on bad credentials #288

Merged
merged 1 commit into from
Jun 23, 2022
Merged

B-283: fail on bad credentials #288

merged 1 commit into from
Jun 23, 2022

Conversation

treywelsh
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Fail on empty credentials.

References

Close #283

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@treywelsh treywelsh changed the title B #283: failed on empty credentials B-283: fail on empty credentials Jun 13, 2022
@treywelsh treywelsh force-pushed the B-283_fail_unset_creds branch 2 times, most recently from de47c23 to bb35658 Compare June 20, 2022 13:18
@treywelsh treywelsh changed the title B-283: fail on empty credentials B-283: fail on bad credentials Jun 20, 2022
Copy link
Collaborator

@frousselet frousselet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my side. Now shows error as expected when using wrong parameters:

$ terraform plan

╷
│ Error: GOCA client error [REQUEST_HTTP]: http make request: Post "https://www.tata.net": dial tcp: lookup www.tata.net: no such host
│
│   with provider["ig1.com/ig1/opennebula"],
│   on main.tf line 10, in provider "opennebula":
│   10: provider "opennebula" {
│
╵

Missing changelog and we are good to merge.

@treywelsh treywelsh marked this pull request as ready for review June 22, 2022 13:46
Copy link
Collaborator

@frousselet frousselet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add changes to CHANGELOG.md

opennebula/provider.go Show resolved Hide resolved
@frousselet frousselet merged commit dd1d518 into master Jun 23, 2022
@frousselet frousselet deleted the B-283_fail_unset_creds branch June 28, 2022 12:45
@frousselet frousselet restored the B-283_fail_unset_creds branch June 28, 2022 12:46
@frousselet frousselet deleted the B-283_fail_unset_creds branch June 28, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running plan or apply without setting the provider should return an error
2 participants