Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets may fail to save validation due to hedIssues field on ValidationIssueFileInput #3162

Open
nellh opened this issue Sep 27, 2024 · 3 comments
Assignees
Labels

Comments

@nellh
Copy link
Contributor

nellh commented Sep 27, 2024

What went wrong?

If hedIssues fields for files are returned by the legacy validator, this is not allowed by the OpenNeuro issue format and these datasets will fail to validate. The parameters field on this field doesn't look well typed, so we either need to filter that or specify it can be any object.

Expected behavior

hedIssues datasets should not fail to validate.

How to reproduce

No response

Desktop

  • OS:
  • Browser:
  • Version:

Phone

  • Device:
  • OS:
  • Browser:
  • Version:

Additional information

No response

@nellh nellh added the bug label Sep 27, 2024
@nellh nellh self-assigned this Sep 27, 2024
@neuromechanist
Copy link

Thanks very much, @nellh,
Please let me know if there is anything we can do wrt HED.

@VisLab
Copy link

VisLab commented Oct 1, 2024

@neuromechanist @nellh This should be fixed by bids-standard/bids-validator#2143

@nellh
Copy link
Contributor Author

nellh commented Oct 2, 2024

Confirming that does fix the issue, I'll close this once it's merged for an OpenNeuro release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants