Map issues through the Issue constructor #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The direct use of BidsIssue/BidsHedIssue was causing issues with downstream tools. Converting them to plain Issue objects should fix this problem. Fixes bids-standard#2142
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
==========================================
+ Coverage 85.72% 85.73% +0.01%
==========================================
Files 91 91
Lines 3782 3785 +3
Branches 1220 1220
==========================================
+ Hits 3242 3245 +3
Misses 454 454
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This should fix OpenNeuroOrg/openneuro#3162. Please merge ASAP. |
|
@nellh Do you want to do any tests before this is merged? |
Yes, I've been working on reviewing it. |
nellh
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direct use of
BidsIssue/BidsHedIssuefromhed-validatorwas causing issues with downstream tools. Converting them to plain Issue objects should fix this problem.Fixes #2142