OO#157 adding kunde konto daten information in rechnung json extract #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlwinEgger
reviewed
Apr 17, 2024
| @@ -63,10 +64,11 @@ trait RechnungReportData extends AsyncConnectionPoolContextAware with Buchhaltun | |||
| case Some(error) if error.startsWith("Error: ") => { | |||
| Left(ValidationError[RechnungId](rechnungId, error)) | |||
| } | |||
| case Some(_) => Right(copyTo[RechnungDetail, RechnungDetailReport](rechnung, "qrCode" -> qrCode, "projekt" -> projektReport, "kontoDaten" -> kontoDaten)) | |||
| case Some(_) => | |||
| val maybeKundeKontoDaten: Option[KontoDaten] = Await.result(stammdatenReadRepository.getKontoDatenKunde(rechnung.kunde.id), d) | |||
There was a problem hiding this comment.
Sure this works. But it might be an option to add the KontoDaten to the RechnungDetail and fetch it with the Query?
…directly from query
…directly from query
…directly from query
|
AlwinEgger
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.