CI: Migrate to DownloadPipelineArtifact@2 task #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React to warning that the DownloadPipelineArtifact@0 task is deprecated and that the latest version of the DownloadPipelineArtifact task shall be used instead.
dl3sdo
force-pushed
the
download-pipeline-artifact
branch
from
61a9f4d
to
e2de6d3
Compare
dg0yt
reviewed
Aug 23, 2024
ci/setup-common.yml
Outdated
Comment on lines
64
to
65
| buildVersionToDownload: 'latest' | ||
| # pipelineId: $(openorienteering.superbuild.buildId) |
There was a problem hiding this comment.
This is the part which is left to resolve: Pick a particular build, not the latest.
(IIRC that's why I didn't update this task yet.)
There was a problem hiding this comment.
If I understand you correct, specifying a particular build instead of the latest one ensures that any yet unstable change of superbuild won't break mapper builds. I now pick the pipeline run that you marked by setting its retention to forever. However, if there is a stable update of superbuild and thus a new pipeline run, then Mapper's setup-common.yml would need to be updated.
BTW: How is the variable openorienteering.superbuild.buildId set? Is this always pointing to the latest build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React to warning that the DownloadPipelineArtifact@0 task is deprecated and that the latest version of the DownloadPipelineArtifact task shall be used instead.