libcups: Don't overwrite permanent queue with network during discovery #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Dec 18, 2024
Currently, if there is a permanent queue of the same name as network discovered printer, the network one is written in `lpstat -l -e` output. This is confusing to users and maintainers, because if print job is sent, it comes to the permanent one instead of listed network/temporary, which can have a different connection or PPD. This behavior happens when user creates manually a queue with the same name as the temporary one, or when the permanent queue is created by cups-browsed. In both cases user realizes he prints into a different queue once he enables debugging and see printer-uri in logs.
zdohnal
force-pushed
the
no-queue-override
branch
from
042591c to
36006d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if there is a permanent queue of the same name as network discovered printer, the network one is written in
lpstat -l -eoutput. This is confusing to users and maintainers, because if print job is sent, it comes to the permanent one instead of listed network/temporary, which can have a different connection or PPD.This behavior happens when user creates manually a queue with the same name as the temporary one, or when the permanent queue is created by cups-browsed. In both cases user realizes he prints into a different queue once he enables debugging and see printer-uri in logs.