Do not open logfiles with read access #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently logfiles are opened with read-access, due to cupsFileOpen() converting "a" into `O_RDWR | O_CREAT | O_APPEND`. This should not be necessary, as logfiles should be an append-only data structure. Update cupsFileOpen() to open files with `O_WRONLY | O_CREAT | O_APPEND` on mode "a" and add a fallback mode "a+" (see man:fopen(3)). Currently only the logfiles and a test file are opened with "a".
|
@cgzones There was a reason for this but I haven’t touched this code in a long time. Will investigate… |
michaelrsweet
requested changes
May 4, 2022
michaelrsweet
added
bug
michaelrsweet
added a commit
that referenced
this pull request
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently logfiles are opened with read-access, due to cupsFileOpen()
converting "a" into
O_RDWR | O_CREAT | O_APPEND. This should not benecessary, as logfiles should be an append-only data structure.
Update cupsFileOpen() to open files with
O_WRONLY | O_CREAT | O_APPENDon mode "a" and add a fallback mode "a+" (see man:fopen(3)).
Currently only the logfiles and a test file are opened with "a".