Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment of programming document in cups web interface Fix #345

Closed
wants to merge 1 commit into from

Conversation

chandresh-soni
Copy link

This fixes issue #344 , Basically, cups web interface has its own header and footer, therefore we shouldn't include them in these html files since they might overlap and cause misalignment. In this modification, I merely changed their class from header to body so that they don't clash with cups web interface header.

Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the online help program to allow for a header div, since this documentation is generated by codedoc and we don't want to have to do this every time the documentation is updated...

@chandresh-soni
Copy link
Author

chandresh-soni commented Mar 3, 2022

@michaelrsweet i think that's little complicated as the header is clashing with cups web interface's header and we can't use two header in single page so we need to change that, could you please tell what i can do now as according to me the only option left is to change template code for header.
the problem only occur for programming manual not in complete help

@chandresh-soni
Copy link
Author

@michaelrsweet could you please tell me what should i do to solve this issue ,like what to change instead of these files

@michaelrsweet
Copy link
Member

@Chandresh2702 I just pushed some changes to the base CUPS stylesheet to use "cups-" prefix on the class names so we don't have this conflict. Those changes also fix the issues with the underline of the headers bleeding into the sidebar.

[master 77bcfb2] Fix some web interface issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants