Save strings file path in printers.conf by Bryan Cain + feedback applied #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Jun 1, 2023
zdohnal
force-pushed
the
Plombo-printer-conf-strings
branch
from
03d71bf to
43b5360
Compare
zdohnal
force-pushed
the
Plombo-printer-conf-strings
branch
from
3c89347 to
a88956a
Compare
|
Aha, I thought the access() call is needed at the top of the Bryan's PR, not replacing it... I hope it is ok now. |
|
@michaelrsweet I would go for release 2.4.3 with this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is the fix by Bryan Cain from #710 with feedback applied, so if it is correct, we can follow up with 2.4.3 soon.