add lang parameter to cfCatalogLoad() and others #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cupsfilters/catalog.c
Outdated
|
|
||
| // Check for language match, with any region | ||
| // Cover both cases, whether locale has region suffix or | ||
| strncpy(lang, preferredlocale, strcspn(preferredlocale, "_")); |
There was a problem hiding this comment.
Do we have the terminating zero here? Or is lang pre-filled with zeros?
There was a problem hiding this comment.
I didn't know strncpy() didn't append a NULL terminator like snprintf() does. Fixed it now. Thanks!
tillkamppeter
pushed a commit
to OpenPrinting/libppd
that referenced
this pull request
Dec 28, 2022
In libcupsfilters we have added language/translation support to the `cfCatalog...()` API functions via OpenPrinting/libcupsfilters#2. This changes the `cfCatalogLoad()` calls in libppd (both in the PPD generator for driverless printing). This commit updates them. For a quick solution we supply NULL as language for now, resembling the old behavior. We look into language support in the PPD generator later.
zdohnal
added a commit
to zdohnal/libcupsfilters
that referenced
this pull request
Feb 10, 2023
zdohnal
added a commit
to zdohnal/libcupsfilters
that referenced
this pull request
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfCatalogSearchDirLocale(): Searches for catalog file matching localecfCatalogSearchDirLang(): Searches for catalog file matching only language prefixcfCatalogSearchDir(): Searches for catalog file matching a preferred locale, but defaults to other locales if not found