Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

universal filter crashes when there is no valid default page size #31

Closed
zdohnal opened this issue Dec 13, 2023 · 0 comments · Fixed by #37
Closed

universal filter crashes when there is no valid default page size #31

zdohnal opened this issue Dec 13, 2023 · 0 comments · Fixed by #37

Comments

@zdohnal
Copy link
Member

zdohnal commented Dec 13, 2023 •
edited
Loading

Answer from ipptool, grepped for default media related settings
full log
:

        media-col-default (collection) = {media-bottom-margin=1 media-left-margin=1 media-right-margin=1 media-size={x-dimension=10160 y-dimension=10252} media-size-name=oe_4x4.03661-label_4x4.03661in media-source=main-roll media-top-margin=1 media-top-offset=0 media-tracking=continuous media-type=labels}
        media-default (keyword) = oe_4x4.03661-label_4x4.03661in

zebra-lprint-perm.ppd.txt

job_log.txt

$ PPD=zebra-lprint-perm.ppd.txt CONTENT_TYPE=text/plain FINAL_CONTENT_TYPE=image/urf /usr/lib/cups/filter/universal 1 root '' 1 '' /etc/fstab > out.ras
DEBUG: ppdFilterLoadPPD: Color profile qualifier determined from job and PPD data 'Gray.Labels.300dpi'
DEBUG: ppdFilterLoadPPD: No ICC profiles specified in PPD
DEBUG: ppdFilterLoadPPD: Searching for profile "-/Labels"...
Segmentation fault (core dumped)

Backtrace

The issue is caused by bug in lprint/pappl, which does not set the correct default page size, but we should end up with error and not with crash.

System Information:
Fedora 39, libppd 2.0.0, lprint 1.2.0, CUPS 2.4.7, pappl 1.4.2
@zdohnal zdohnal changed the title universal filter crashes when there is no default page size universal filter crashes when there is no valid default page size Dec 13, 2023
zdohnal added a commit to zdohnal/libppd that referenced this issue Jan 11, 2024
@zdohnal
ppd-ipp.c: Fix crash if ppd_size is NULL
848b899 
In some cases `ppd_size` can be NULL after `ppdPageSize()` - in such
cases a program using libppd will crash because the pointer is accessed
later.

Fixes OpenPrinting#31
@zdohnal zdohnal mentioned this issue Jan 11, 2024
Merged
tillkamppeter pushed a commit that referenced this issue Mar 8, 2024
@zdohnal
ppd-ipp.c: Fix crash if ppd_size is NULL (#37)
d17b102 
In some cases `ppd_size` can be NULL after `ppdPageSize()` - in such
cases a program using libppd will crash because the pointer is accessed
later.

Fixes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ppd-ipp.c: Fix crash if ppd_size is NULL zdohnal/libppd
1 participant
@zdohnal