Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: upgrade license-checker-rseidelsohn #8640

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Aug 30, 2024

Test files have been dropped from this package's tarball, so the size of the on-disk node_modules/license-checker-rseidelsohn directory goes from 148.1 MiB down to 3.1 MiB.

Also move to a dev dependency since it's only used at build-time.

@emersion emersion requested a review from a team as a code owner August 30, 2024 08:53
@emersion emersion requested review from Akctarus and removed request for hamz2a August 30, 2024 08:55
@emersion emersion force-pushed the emr/upgrade-license-checker branch 2 times, most recently from 31322e2 to d3722b4 Compare August 30, 2024 09:19
@emersion emersion self-assigned this Aug 30, 2024
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@emersion
Copy link
Member Author

emersion commented Sep 2, 2024

Test files have been dropped from this package's tarball, so the
size of the on-disk node_modules/license-checker-rseidelsohn
directory goes from 148.1 MiB down to 3.1 MiB.

Also move to a dev dependency since it's only used at build-time.
@emersion emersion added this pull request to the merge queue Sep 9, 2024
Merged via the queue into dev with commit 172ded8 Sep 9, 2024
22 checks passed
@emersion emersion deleted the emr/upgrade-license-checker branch September 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants