Coverity #3472
Merged
Coverity #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemenkov
reviewed
Sep 18, 2024
| @@ -769,6 +769,9 @@ mi_response_t *w_mi_subscribers_list_1(const mi_params_t *params, | |||
| return init_mi_error(404, MI_SSTR("Event not published")); | |||
| /* get the event id & before printing the subs list check for any expired subscribers and remove them*/ | |||
| evid = evi_get_id(&event_s); | |||
| if (evid == -1) | |||
| return init_mi_error(404, MI_SSTR("Can't get the id")); | |||
|
|
|||
There was a problem hiding this comment.
Thank you for pointing that out!
lemenkov
reviewed
Sep 18, 2024
| @@ -44,17 +44,18 @@ int extract_pub_key_from_cert(struct sip_msg* _msg, str* cert, | |||
|
|
|||
| /* TODO - if x5c just add beggining & end */ | |||
|
|
|||
| if (cert == NULL) { | |||
oanatitoc
force-pushed
the
coverity
branch
7 times, most recently
from
ab35ad0
to
7a5c829
Compare
…condition CID #417568, #417618
CID #417542, #417562, #417674, #417768, #417771
CID #417476, #417752
CID #417754
CID #417472
CID #417489, #417750
CID #417441
CID #417477
CID #417525
CID #417728
CID #417652
CID #417634, #417733
CID #417804
CID #207906
CID #417449, #417515, #417685, #417763
CID #417496
CID #417549
CID #417577
CID #417823
CID #40852
CID #40762
CID #417552, #417702
CID #417694, #417767, #417456
CID #40763, #40764
CID #417450
CID #417719, #417510
CID #417545
CID #417617, #417773, #417451, #417759
CID #417806
CID #417493
CID #417655, #417442, #417801, #417808
CID #417626
CID #417657
CID #417440
CID #417550
CID #417620, #417646
* MongoDB: goto "out_err" in the new if-block, to free the resources * mid-registrar: on mid_reg_save() quick-exit, check .flags before reply * EVI: fix "infinite loop" bug in evi_remove_expired_subs() * various whitespace fixes
Completes commit 4c8fc99 solving CID #417715
This reverts commit 1e4bd24.
Fixes CID #417802
Complete 607d178, fixes CID #40852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.