Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mints and redemptions public #100

Merged
merged 2 commits into from
Jan 31, 2018
Merged

Make mints and redemptions public #100

merged 2 commits into from
Jan 31, 2018

Conversation

jasonklein
Copy link
Contributor

@jasonklein jasonklein commented Jan 30, 2018 •
edited
Loading

Adds public visibility modifier to mints and redemptions and adds matching function signatures to OpenSTUtilityInterface. Does not lint, to minimize conflicts with #97.

Fixes #96.

@jasonklein jasonklein added this to the v0.9.2 milestone Jan 30, 2018
@jasonklein jasonklein mentioned this pull request Jan 30, 2018
Merged
benjaminbollen
benjaminbollen approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminbollen benjaminbollen merged commit ee42906 into develop Jan 31, 2018
@jasonklein jasonklein mentioned this pull request Feb 5, 2018
Closed
@jasonklein jasonklein modified the milestones: v0.9.2, v0.9.3 Mar 27, 2018
@benjaminbollen benjaminbollen deleted the jasonbanks/gh96/expose-mints-redemptions branch June 4, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminbollen benjaminbollen benjaminbollen approved these changes

Assignees

@benjaminbollen benjaminbollen

Labels
None yet
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonklein @benjaminbollen