Votes should be hashed according to EIP-712 #335 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schemar
reviewed
Oct 22, 2018
contracts/core/PollingPlace.sol
Outdated
| _v, | ||
| _r, | ||
| _s | ||
| ); | ||
| _s); |
There was a problem hiding this comment.
Suggested change
| _s); | |
| _s | |
| ); |
|
|
schemar
approved these changes
Oct 23, 2018
contracts/core/PollingPlace.sol
Outdated
| /** Vote message */ | ||
| struct VoteMessage { | ||
|
|
||
| /** A unique identifier that identifies what chain this vote is about. */ |
There was a problem hiding this comment.
Please also explain here why it has to be part of the struct.
There was a problem hiding this comment.
Added the comment 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #335
struct VoteMessagestruct VotePlease note: In this PR
bytes20 coreIdentifieris still part ofstruct VoteMessage.As the votes are for both origin and auxiliary chain, we need to have the
coreIdentifierinformation while generating thevoteHash.