Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure for v0.9.1 to separate value from logic #5

Merged
merged 17 commits into from
Nov 24, 2017

Conversation

benjaminbollen
Copy link
Contributor

Refactor for v0.9.1: separate value staked into SimpleStake out of the versioned logic contract OpenSTValue; similarly BrandedToken.sol and STPrime.sol hold the utility tokens on the utility chain separate from the logic in OpenSTUtility.sol

Refactor is done up to staking, to be done for unstaking.

fixes #2

@benjaminbollen benjaminbollen changed the title Benjaminbollen/gh2/prefixchain Restructure for v0.9.1 to separate value from logic Nov 24, 2017
Copy link
Contributor

@jasonklein jasonklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the backslash mania in UtilityTokenAbstract.sol. But that doesn't need to hold up merging.

totalTokenSupply = 0;
}

// /// @dev transfer full claim to beneficiary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backslash mania

@jasonklein jasonklein merged commit 8b2a550 into master Nov 24, 2017
@benjaminbollen benjaminbollen deleted the benjaminbollen/gh2/prefixchain branch November 27, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants