-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure for v0.9.1 to separate value from logic #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminbollen
changed the title
Benjaminbollen/gh2/prefixchain
Restructure for v0.9.1 to separate value from logic
Nov 24, 2017
…chain they belong on - fixes #2
benjaminbollen
force-pushed
the
benjaminbollen/gh2/prefixchain
branch
from
November 24, 2017 14:44
dbbd840
to
087e91a
Compare
This was referenced Nov 24, 2017
jasonklein
approved these changes
Nov 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the backslash mania in UtilityTokenAbstract.sol
. But that doesn't need to hold up merging.
totalTokenSupply = 0; | ||
} | ||
|
||
// /// @dev transfer full claim to beneficiary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backslash mania
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor for v0.9.1: separate value staked into SimpleStake out of the versioned logic contract OpenSTValue; similarly BrandedToken.sol and STPrime.sol hold the utility tokens on the utility chain separate from the logic in OpenSTUtility.sol
Refactor is done up to staking, to be done for unstaking.
fixes #2