Mint ost prime as base token #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 18, 2018 20:55
0xsarvesh
requested review from
schemar,
benjaminbollen,
deepesh-kn and
gulshanvasnani
schemar
suggested changes
Dec 19, 2018
contracts/gateway/OSTPrime.sol
Outdated
| * Acquire lock for msg.sender so that this function can only be | ||
| * executed once in a transaction. | ||
| */ | ||
|
|
contracts/lib/Mutex.sol
Outdated
| ); | ||
|
|
||
| locks[msg.sender] = true; | ||
| success_ = true; |
There was a problem hiding this comment.
Maybe isAcquired_? Required?
test/lib/mutex/release.js
Outdated
| mutex.releaseExternal(address), | ||
| 'Lock is not acquired for the address.' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Please add it('should only release the lock of the given address') (and not any other locked address).
There was a problem hiding this comment.
is it not the same as this test `it('should release lock for an address') 🤔
There was a problem hiding this comment.
You are not checking that it does not release the lock of another address at the same time.
deepesh-kn
reviewed
Dec 19, 2018
added 3 commits
December 20, 2018 10:50
…and contract licence
…vesh-ost/mosaic-contracts into mint_ost_prime_as_base_token
schemar
reviewed
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545
This PR implements the following features:
increaseSupplytransfers base token to the beneficiary.increaseSupplyMutex is implemented in
increaseSupplyto avoid possible Reentrancy Attack..In
OSTPrime.increaseSupply(),address.transfer()is used to send base tokens.transfermethod ensure that only 2300 gas is passed as "gas stipend" to the payable fallback function of attacker contract. This makes it difficult for an attacker to call any method which updates storage from fallback.Theoretically, it's almost impossible to do reentrancy attack on
increase supply.For the safer side mutex locking is implemented for
increaseSupplyas solidity document also mention that 2300 gas "gas stipend" can possibly change in future.Quote: