Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getter function to get message status for a given message hash. #602

Merged
merged 10 commits into from
Jan 22, 2019
Merged

Add getter function to get message status for a given message hash. #602

merged 10 commits into from
Jan 22, 2019

Conversation

deepesh-kn
Copy link
Contributor

  • Added getOutboxMessageStatus() function.
  • Added getInboxMessageStatus() function.
  • Added corresponding test cases.

fixes: #594

@deepesh-kn deepesh-kn self-assigned this Jan 18, 2019
0xsarvesh
0xsarvesh approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@0xsarvesh 0xsarvesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

contracts/test/gateway/TestGatewayBase.sol Outdated Show resolved Hide resolved
schemar
schemar suggested changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛴
Only tiny comments.

contracts/gateway/GatewayBase.sol Outdated Show resolved Hide resolved
contracts/gateway/GatewayBase.sol Outdated Show resolved Hide resolved
@schemar schemar merged commit a7e6982 into OpenST:develop Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xsarvesh 0xsarvesh 0xsarvesh approved these changes

@schemar schemar schemar approved these changes

Assignees

@deepesh-kn deepesh-kn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getter function to get message status.
3 participants
@deepesh-kn @schemar @0xsarvesh