Unit test case uncommented for complete protocol with mock contract f… #66
Conversation
…or protocol versioning
|
|
||
| function blocksToWaitForProtocolTransfer() public pure returns (uint256) { | ||
| return PROTOCOL_TRANSFER_BLOCKS_TO_WAIT; | ||
| } |
There was a problem hiding this comment.
@jasonklein curious to know if blocksToWaitForProtocolTransfer is needed in ProtocolVersionedMock.sol?
This method is already there in ProtocolVersioned.sol. I guess solidity should inherit blocksToWaitForProtocolTransfer from ProtocolVersioned.sol to ProtocolVersionedMock.sol.
There was a problem hiding this comment.
@abhayks1: sorry, I merged before I saw this question! Yes, you need to overwrite because
ProtocolVersioned.blocksToWaitForProtocolTransfer points to the PROTOCOL_TRANSFER_BLOCKS_TO_WAIT constant scoped to it, and not scoped to ProtocolVersionedMock.
There was a problem hiding this comment.
Thanks Banks for clarifying. Solidity is little different in method overriding as compared to other languages like Java, Ruby :)
…or protocol versioning