Penalty is now burned on revert stake and redeem instead of progress … #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Revert also penalty is not returned on progress with proof
benjaminbollen
previously approved these changes
Mar 14, 2019
| @@ -660,6 +614,10 @@ contract EIP20CoGateway is GatewayBase { | |||
| redeemerNonce_ = message.nonce; | |||
| amount_ = redeems[_messageHash].amount; | |||
|
|
|||
|
|
|||
| // Burn penalty amount. Reentrancy is protected by message bus states. | |||
There was a problem hiding this comment.
👍 great to have put the comment on reentrancy consideration
| `CoGateway's token balance ${eip20CoGatewayFinalBalance.toString( | ||
| 10, | ||
| )} must be equal to ${eip20CoGatewayBalance.toString(10)}.`, | ||
| `CoGateway's token balance ${eip20CoGatewayBalance.toString(10)}` |
There was a problem hiding this comment.
same param used here twice, seems incorrect; perhaps FinalBalance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #662 partially
The penalty is not returned on progress with proof(stake and redeem) instead it is now burned on revert stake and revert redeem.