Updated OSTPrime contract and tests. #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulshanvasnani
suggested changes
Dec 10, 2018
added 4 commits
December 10, 2018 21:11
… less than the available balance
schemar
suggested changes
Dec 10, 2018
0xsarvesh
reviewed
Dec 11, 2018
|
|
||
| let brandedTokenAddress, ostPrime, callerAddress, amount; | ||
|
|
||
| async function initialize(){ |
There was a problem hiding this comment.
This is used in both wrap and unwrap, can be extracted out.
Also the config of OSTPrime.
0xsarvesh
approved these changes
Dec 12, 2018
schemar
approved these changes
Dec 12, 2018
My confidence level is very good. |
This is the same as one of the existing test. |
|
LGTM |
gulshanvasnani
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #417
Claimevent is renamed toTokenUnwrapped.Redeemevent is renamed toTokenWrapped.-
uint256 _totalSupplyandaddress _utilityTokenparams are removed from both the events as it is not needed.initializefunction can be called only once.claimfunction is renamed tounwrap.redeemfunction is renamed towrap.wrapandunwrapfunctions are modified.Please note: The unit tests for UtilityToken and EIP20Token is not covered in this. They are the separate tests.