Integration of resvg SVG library (optional during build) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Major refactor of max_width and max_height for preview optimization * Fixed many bugs related to preview resizing, with regards to cached frames
|
Linux and Mac build servers have resvg manually compiled and available at the moment, so our official AppImage and DMG files will support resvg out of the box. Windows support is still being worked on (but I'm hopeful it will be available soon as well). Linux distros will take much longer before resvg is widely available in repos. |
RazrFalcon
reviewed
Jan 18, 2019
…, to prevent an issue on our windows builders.
…n different named fodlers. This is an attempt to fix Windows include issues.
…ause it crashes on Windows for seemingly no reason). Needs more investigation.
|
As long as you build and install libresvg.so|dylib into the following places, libopenshot will automatically detect it and link against it: /usr/local/lib/libresvg.so (found in target/release/.so) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will take a while for resvg to be packaged in the various Linux distros. It is a rust library, and uses cargo for it's build process. I was unable to include the package in our PPA due to the dependency on cargo (and GitHub is internally used, which is forbidden on LaunchPad's build servers). The Debian packaging will require much more effort than I had hoped, since each cargo dependency would need to be replaced with Debian packages, etc...