Add fallback for AVFrame.pkt_dts (certain codecs fail to find a valid video PTS) #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #867 +/- ##
===========================================
- Coverage 51.08% 51.07% -0.01%
===========================================
Files 184 184
Lines 16063 16065 +2
===========================================
Hits 8206 8206
- Misses 7857 7859 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression caused by recent PTS changes, and apparently certain video codecs, such as AV1, do not correctly set the AVFrame->pts field, and instead rely on the AVFrame->pkt_dts. Strange, but the fix is a simple fallback.